Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clustering/rpc): connection lost event #14257

Closed
wants to merge 1 commit into from
Closed

feat(clustering/rpc): connection lost event #14257

wants to merge 1 commit into from

Conversation

StarlightIbuki
Copy link
Contributor

Summary

Emit an event when the connection is lost

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Precondition for KAG-6178

@github-actions github-actions bot added core/clustering size/S cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Feb 11, 2025
@StarlightIbuki StarlightIbuki added skip-changelog and removed core/clustering size/S cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Feb 11, 2025
chronolaw
chronolaw reviewed Feb 11, 2025
View reviewed changes
kong/clustering/rpc/manager.lua Outdated Show resolved Hide resolved
kong/clustering/rpc/manager.lua Outdated Show resolved Hide resolved
kong/clustering/rpc/manager.lua Show resolved Hide resolved
@chronolaw chronolaw changed the title feat(rpc): connection lost event feat(clustering/rpc): connection lost event Feb 12, 2025
@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Feb 12, 2025
@lhanjian lhanjian self-requested a review February 12, 2025 07:28
@chronolaw
Copy link
Contributor

#14279 may replace this PR.

@chobits
Copy link
Contributor

chobits commented Feb 14, 2025

hi @StarlightIbuki im clisng this , because another pr is trying to resolve this and includes other modificaitons

@chobits chobits closed this Feb 14, 2025
@chronolaw chronolaw deleted the feat/disconnect-event branch February 14, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chobits chobits chobits left review comments

@chronolaw chronolaw chronolaw left review comments

@lhanjian lhanjian Awaiting requested review from lhanjian

Assignees

@StarlightIbuki StarlightIbuki

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/XS skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StarlightIbuki @chronolaw @chobits